vine: add up peer transfer ids during scheduling #3958
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Previously we would only add peer transfers to the transfer table in
vine_manager_put_url
after the task had been scheduled.If a task had many input files, such as temporaries that reside on one worker, we would be happy to assign them all to be retrieved from the same worker in the scheduling stage, greater than the limit for transfers from a single source, since the task has not been sent yet and we were not incrementing the
source_in_use
count.In some fashion we need to increment the
source_in_use
count while considering options for peer transfers. It is a bit difficult since there are a few scenarios we give up scheduling so any counting we did in the scheduling attempt needs to get reset.Merge Checklist
The following items must be completed before PRs can be merge.
Check these off to verify you have completed all steps.
make test
Run local tests prior to pushing.make format
Format source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)make lint
Run lint on source code prior to pushing.